chore(runway): cherry-pick fix(navigation): use transparentModal presentation for all feature modal stacks cp-7.73.0#28677
Open
runway-github[bot] wants to merge 1 commit intorelease/7.73.0from
Conversation
…entation for all feature modal stacks cp-7.73.0 (#28630) ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> The `EarnModalStack` was recently updated to use `clearStackNavigatorOptions` spread with `presentation: 'transparentModal'` in both the route file `screenOptions` and the `MainNavigator.js` screen options. This PR applies the same consistent pattern to the remaining feature modal stacks: - **`BridgeModalStack`** (`app/components/UI/Bridge/routes.tsx`): `presentation: 'modal'` → `'transparentModal'` - **`StakeModalStack`** (`app/components/UI/Stake/routes/index.tsx`): `presentation: 'modal'` → `'transparentModal'` - **`PerpsModalStack`** (`app/components/UI/Perps/routes/index.tsx`): replaced inline custom `screenOptions` (with bespoke `cardStyleInterpolator`) with the shared `clearStackNavigatorOptions` spread + `presentation: 'transparentModal'`; also added missing `presentation: 'transparentModal'` to the `MainNavigator.js` screen entry - **`PredictModalStack`** (`app/components/UI/Predict/routes/index.tsx`): replaced inline `headerShown`/`cardStyle` options with the shared `clearStackNavigatorOptions` spread; reordered `MainNavigator.js` screen entry so `presentation` overrides the spread (consistent with Earn) This ensures all feature modal stacks use the same transparent overlay presentation style and reduces per-stack boilerplate in favour of the shared `clearStackNavigatorOptions` constant. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: Feature modal stacks transparent overlay presentation Background: Given I am logged into MetaMask Mobile Scenario: Bridge modal overlays render transparently Given I am on the Bridge screen When a modal (e.g. slippage, network list, price impact) is triggered Then the modal appears as a transparent overlay over the existing screen And the background content remains visible behind the modal Scenario: Stake modal overlays render transparently Given I am on the Stake screen When a modal (e.g. learn more, max input, gas impact) is triggered Then the modal appears as a transparent overlay And the background content remains visible Scenario: Perps modal overlays render transparently Given I am on the Perps screen And the Perps feature flag is enabled When a modal (e.g. quote expired, GTM, close all positions) is triggered Then the modal appears as a transparent overlay And the background content remains visible Scenario: Predict modal overlays render transparently Given I am on the Predict screen And the Predict feature flag is enabled When a modal (e.g. unavailable, GTM, add funds) is triggered Then the modal appears as a transparent overlay And the background content remains visible ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Generated with the help of the pr-description AI skill --> Made with [Cursor](https://cursor.com) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes React Navigation modal presentation across multiple feature stacks; risk is mainly UI/UX regressions (overlay behavior, gestures, stacking) in Bridge/Stake/Perps/Predict flows. > > **Overview** > **Standardizes feature modal navigation to use transparent overlays.** Bridge, Stake, Earn, Perps, and Predict modal stacks now use `presentation: 'transparentModal'` (instead of `'modal'`) and consistently apply shared `clearStackNavigatorOptions`. > > **Reduces per-stack boilerplate and aligns MainNavigator options.** Inline modal `screenOptions` in Perps/Predict are replaced with the shared options, `MainNavigator` sets `transparentModal` for the corresponding modal-root screens, and snapshots are updated accordingly. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit edc0046. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The
EarnModalStackwas recently updated to useclearStackNavigatorOptionsspread withpresentation: 'transparentModal'in both the route filescreenOptionsand theMainNavigator.jsscreen options. This PR applies the same consistentpattern to the remaining feature modal stacks:
BridgeModalStack(app/components/UI/Bridge/routes.tsx):presentation: 'modal'→'transparentModal'StakeModalStack(app/components/UI/Stake/routes/index.tsx):presentation: 'modal'→'transparentModal'PerpsModalStack(app/components/UI/Perps/routes/index.tsx):replaced inline custom
screenOptions(with bespokecardStyleInterpolator) with the sharedclearStackNavigatorOptionsspread +
presentation: 'transparentModal'; also added missingpresentation: 'transparentModal'to theMainNavigator.jsscreenentry
PredictModalStack(
app/components/UI/Predict/routes/index.tsx): replaced inlineheaderShown/cardStyleoptions with the sharedclearStackNavigatorOptionsspread; reorderedMainNavigator.jsscreenentry so
presentationoverrides the spread (consistent with Earn)This ensures all feature modal stacks use the same transparent overlay
presentation style and reduces per-stack boilerplate in favour of the
shared
clearStackNavigatorOptionsconstant.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Made with Cursor
Note
Medium Risk
Changes React Navigation modal presentation across multiple feature
stacks; risk is mainly UI/UX regressions (overlay behavior, gestures,
stacking) in Bridge/Stake/Perps/Predict flows.
Overview
Standardizes feature modal navigation to use transparent overlays.
Bridge, Stake, Earn, Perps, and Predict modal stacks now use
presentation: 'transparentModal'(instead of'modal') andconsistently apply shared
clearStackNavigatorOptions.Reduces per-stack boilerplate and aligns MainNavigator options.
Inline modal
screenOptionsin Perps/Predict are replaced with theshared options,
MainNavigatorsetstransparentModalfor thecorresponding modal-root screens, and snapshots are updated accordingly.
Reviewed by Cursor Bugbot for commit
edc0046. Bugbot is set up for automated
code reviews on this repo. Configure
here.