Skip to content

test: fixed component view test#28682

Merged
javiergarciavera merged 1 commit intofix/perps-market-insights-geo-blockfrom
MMQA-fix-component-view-test-market-details
Apr 10, 2026
Merged

test: fixed component view test#28682
javiergarciavera merged 1 commit intofix/perps-market-insights-geo-blockfrom
MMQA-fix-component-view-test-market-details

Conversation

@javiergarciavera
Copy link
Copy Markdown
Contributor

@javiergarciavera javiergarciavera commented Apr 10, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk test-only change that adjusts component-view rendering behavior; main risk is breaking navigation assertions if provider wrapping alters route props or stack behavior.

Overview
Updates renderPerpsView test renderer so all extraRoutes screens (both root stack and Routes.PERPS.ROOT nested stack) are wrapped with the same Perps providers (AccessRestrictedProvider, PerpsConnectionContext, PerpsStreamProvider) as the primary view. This ensures extra routes can render real Perps views (not just probes) without missing-context errors during component-view tests.

Reviewed by Cursor Bugbot for commit b3dae39. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main or a release branch (base: fix/perps-market-insights-geo-block)

All E2E tests pre-selected.

View GitHub Actions results

@javiergarciavera javiergarciavera added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 10, 2026
@javiergarciavera javiergarciavera merged commit 40d8e04 into fix/perps-market-insights-geo-block Apr 10, 2026
52 of 58 checks passed
@javiergarciavera javiergarciavera deleted the MMQA-fix-component-view-test-market-details branch April 10, 2026 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants