Skip to content

fix: navigation default settings transitions cp-7.73.0#28690

Merged
weitingsun merged 1 commit intomainfrom
wsun/fix-default-settings-transitions
Apr 10, 2026
Merged

fix: navigation default settings transitions cp-7.73.0#28690
weitingsun merged 1 commit intomainfrom
wsun/fix-default-settings-transitions

Conversation

@weitingsun
Copy link
Copy Markdown
Contributor

@weitingsun weitingsun commented Apr 10, 2026

Description

Transitioning from default settings to each individual tab is not working correctly

Screen.Recording.2026-04-09.at.12.42.21.PM.mov

transition

Changelog

CHANGELOG entry: fix default settings navigation

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI/navigation configuration change; could subtly affect onboarding stack visuals (background/header) and transition behavior but does not touch business logic or data handling.

Overview
Fixes the broken transition from DefaultSettings into the individual onboarding settings screens by moving background/header styling into Stack.Navigator-level screenOptions for OnboardingSuccessFlow, and removing per-screen overrides.

Also standardizes OnboardingNav card background via navigator screenOptions (dropping redundant per-screen cardStyle) to keep transitions visually consistent.

Reviewed by Cursor Bugbot for commit 25a8f51. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@weitingsun weitingsun marked this pull request as ready for review April 10, 2026 19:43
@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@weitingsun weitingsun self-assigned this Apr 10, 2026
@weitingsun weitingsun changed the title fix: navigation default settings transitions fix: navigation default settings transitions cp-7.73.0 Apr 10, 2026
@weitingsun weitingsun enabled auto-merge April 10, 2026 20:11
@weitingsun weitingsun added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit 0a2700f Apr 10, 2026
261 of 265 checks passed
@weitingsun weitingsun deleted the wsun/fix-default-settings-transitions branch April 10, 2026 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 size-S team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants