chore(runway): cherry-pick fix: navigation default settings transitions cp-7.73.0#28692
Conversation
…ns cp-7.73.0 (#28690) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Transitioning from default settings to each individual tab is not working correctly https://github.com/user-attachments/assets/21b9940a-68b9-4c40-a10b-aba54b7996d7  ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix default settings navigation ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI/navigation configuration change; could subtly affect onboarding stack visuals (background/header) and transition behavior but does not touch business logic or data handling. > > **Overview** > Fixes the broken transition from `DefaultSettings` into the individual onboarding settings screens by moving background/header styling into `Stack.Navigator`-level `screenOptions` for `OnboardingSuccessFlow`, and removing per-screen overrides. > > Also standardizes `OnboardingNav` card background via navigator `screenOptions` (dropping redundant per-screen `cardStyle`) to keep transitions visually consistent. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 25a8f51. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
github-actions
bot
added
size-S
risk-low
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
This is a cosmetic refactor that consolidates styling at the navigator level rather than per-screen. The functional behavior of the onboarding navigation should be unchanged. Why these tags:
Why not all tags: The change is isolated to onboarding navigation styling only. It does not affect confirmations, trading, network management, ramps, snaps, or any other feature area. Running all tags would be excessive for this low-risk styling change. Performance tests: Not needed — this is a styling refactor with no impact on rendering performance, data loading, or app startup beyond the onboarding screens, which are not covered by any performance test tag. Performance Test Selection: |
|
|
✅ E2E Fixture Validation — Schema is up to date |
3 participants
Description
Transitioning from default settings to each individual tab is not
working correctly
Screen.Recording.2026-04-09.at.12.42.21.PM.mov
Changelog
CHANGELOG entry: fix default settings navigation
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Low risk UI/navigation configuration change; could subtly affect
onboarding stack visuals (background/header) and transition behavior but
does not touch business logic or data handling.
Overview
Fixes the broken transition from
DefaultSettingsinto the individualonboarding settings screens by moving background/header styling into
Stack.Navigator-levelscreenOptionsforOnboardingSuccessFlow, andremoving per-screen overrides.
Also standardizes
OnboardingNavcard background via navigatorscreenOptions(dropping redundant per-screencardStyle) to keeptransitions visually consistent.
Reviewed by Cursor Bugbot for commit
25a8f51. Bugbot is set up for automated
code reviews on this repo. Configure
here.