Skip to content

chore(ci): improve bundle size check#28695

Open
joaoloureirop wants to merge 1 commit intomainfrom
ci/improve-bundle-size-check
Open

chore(ci): improve bundle size check#28695
joaoloureirop wants to merge 1 commit intomainfrom
ci/improve-bundle-size-check

Conversation

@joaoloureirop
Copy link
Copy Markdown
Contributor

@joaoloureirop joaoloureirop commented Apr 10, 2026

Description

Updates the JS bundle size check CI job so that on pull requests it compares the generated ios/main.jsbundle against the bundle built at the merge base of the PR and the base branch, and writes a markdown summary (sizes and delta) to the job summary. The workflow uses a full clone (fetch-depth: 0) so git merge-base works, then restores the PR HEAD bundle before the existing upload-artifact step so downstream jobs still receive the PR’s bundle.

Note: The previous 55 MB ceiling enforced by ./scripts/js-bundle-stats.sh is no longer invoked in this job; the change focuses on PR delta visibility rather than a fixed max-size failure.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-476

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@joaoloureirop joaoloureirop marked this pull request as ready for review April 10, 2026 22:17
@joaoloureirop joaoloureirop requested a review from a team as a code owner April 10, 2026 22:17
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-S team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants