Skip to content

chore(runway): cherry-pick fix: perp and short transition cp-7.73.0#28700

Merged
tommasini merged 2 commits intorelease/7.73.0from
runway-cherry-pick-7.73.0-1775862899
Apr 10, 2026
Merged

chore(runway): cherry-pick fix: perp and short transition cp-7.73.0#28700
tommasini merged 2 commits intorelease/7.73.0from
runway-cherry-pick-7.73.0-1775862899

Conversation

@runway-github
Copy link
Copy Markdown
Contributor

@runway-github runway-github bot commented Apr 10, 2026

Description

Fix perps and short transition

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Screen.Recording.2026-04-10.at.20.06.29.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Touches React Navigation screen options for the perps confirmation
flow, which can affect modal presentation/transition behavior and header
visibility across routes.

Overview
Adjusts the perps RedesignedConfirmations screen options to
explicitly return StackNavigationOptions and always use presentation: 'transparentModal', while keeping the conditional perps header
behavior.

This is intended to fix the perps/short transition behavior by
ensuring confirmations are presented with a consistent transparent modal
configuration.

Reviewed by Cursor Bugbot for commit
ccdf1f4. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[5517bff](https://github.com/MetaMask/metamask-mobile/commit/5517bffad8066e75ed89c76203b0372d2a2bffe4)

…28689)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Fix perps and short transition
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


https://github.com/user-attachments/assets/c922da17-10ce-4ed4-b1c0-7690cbe8471b


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Touches React Navigation screen options for the perps confirmation
flow, which can affect modal presentation/transition behavior and header
visibility across routes.
> 
> **Overview**
> Adjusts the perps `RedesignedConfirmations` screen options to
explicitly return `StackNavigationOptions` and always use `presentation:
'transparentModal'`, while keeping the conditional perps header
behavior.
> 
> This is intended to fix the perps/short transition behavior by
ensuring confirmations are presented with a consistent transparent modal
configuration.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
ccdf1f4. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github bot requested a review from a team as a code owner April 10, 2026 23:15
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Apr 10, 2026
@github-actions github-actions bot added size-S risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change in app/components/UI/Perps/routes/index.tsx makes two modifications:

  1. Type-only import of StackNavigationOptions - no runtime impact.
  2. Return type annotation added to getRedesignedConfirmationsHeaderOptions - no runtime impact.
  3. presentation: 'transparentModal' added to both branches of the navigation options for the Perps confirmation screen - this IS a functional change that affects how the RedesignedConfirmations screen is presented in the Perps flow.

The presentation: 'transparentModal' change means the confirmation screen will now render as a transparent modal overlay instead of a standard stack screen. This could affect:

  • Visual appearance of the confirmation screen in Perps flows
  • Screen transition animations
  • How the background content is visible during confirmation

Tag selection rationale:

  • SmokePerps: Directly affected - this is the Perps navigation routes file, and the confirmation presentation change affects the Add Funds/deposit flow.
  • SmokeConfirmations: Required per SmokePerps tag description ("Add Funds deposits are on-chain transactions"), and this change specifically modifies the confirmation screen presentation options.
  • SmokeWalletPlatform: Required per SmokePerps tag description ("also select SmokeWalletPlatform (Trending section)") since Perps is embedded in the Trending tab.

No performance tests needed - this is a navigation presentation style change with no expected performance impact on rendering times or data loading.

Performance Test Selection:
The change adds presentation: 'transparentModal' to navigation options in the Perps routes file. This is a navigation presentation style change that affects screen transition behavior, not rendering performance, data loading, or any performance-critical paths. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@tommasini tommasini enabled auto-merge (squash) April 10, 2026 23:43
@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@tommasini tommasini disabled auto-merge April 10, 2026 23:57
@tommasini tommasini merged commit a126cf4 into release/7.73.0 Apr 10, 2026
7 of 9 checks passed
@tommasini tommasini deleted the runway-cherry-pick-7.73.0-1775862899 branch April 10, 2026 23:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2026
@github-actions github-actions bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-medium Moderate testing recommended · Possible bug introduction risk size-S team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants