feat: full-page account selector and optional picker dropdown icon#28701
feat: full-page account selector and optional picker dropdown icon#28701
Conversation
…t UI with modal - Always use full-page account list (drop selectFullPageAccountListEnabledFlag) - Swap BottomSheet overlay and BottomSheetFooter for Modal and inline footer buttons - Update unit tests for full-page and add-wallet modal behavior Made-with: Cursor
…ckerAccount - Default keeps existing dropdown arrow for other pickers - PickerAccount omits prop and always hides the icon Made-with: Cursor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7ee2d30. Configure here.
| expect(icon).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should not render dropdown icon when showDropdownIcon is false', () => { |
There was a problem hiding this comment.
New test name uses banned "should" prefix
Low Severity
The newly added test 'should not render dropdown icon when showDropdownIcon is false' uses the word "should" in its name. The unit testing guidelines state: "NEVER use 'should' in test names — this is a hard rule with zero exceptions." An action-oriented name like 'hides dropdown icon when showDropdownIcon is false' would comply.
Triggered by project rule: Unit Testing Guidelines
Reviewed by Cursor Bugbot for commit 7ee2d30. Configure here.
|
✅ E2E Fixture Validation — Schema is up to date |
2 participants
Description
This PR consolidates the account selector on the full-page experience and removes the feature flag that toggled it. The add-wallet / add-account flow no longer uses bottom sheet components; it opens in a standard
Modalwith the same headers and actions as before.PickerBasegains an optionalshowDropdownIconprop (defaulttrue).PickerAccountalways passesfalseso the wallet account picker no longer shows a trailing dropdown arrow, while other pickers keep the previous behavior.Changelog
CHANGELOG entry: Updated the account selector to use the full-page list for all users and removed the dropdown arrow from the wallet account picker.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
N/A
After
Screen.Recording.2026-04-10.at.7.39.28.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Moderate UI/navigation change:
AccountSelectorflow is refactored to always use the full-page experience and the add-wallet flow now uses aModal, which could affect navigation/animation behavior across platforms.Overview
Account selection UI is consolidated to the full-page experience.
AccountSelectorno longer branches on the full-page feature flag or uses bottom sheet components; it always renders the sliding full-page view and opens add-wallet/add-account flows in a standardModal.Picker dropdown icon can now be disabled.
PickerBaseaddsshowDropdownIcon(defaulttrue) andPickerAccounthard-disables it to remove the trailing arrow; tests are updated/added to assert the icon is (not) rendered and account-selector tests drop the feature-flag coverage while validating the new modal overlay behavior.Reviewed by Cursor Bugbot for commit 7ee2d30. Bugbot is set up for automated code reviews on this repo. Configure here.