chore(runway): cherry-pick fix: Fix UI issue related to SafeAreaView top inset recalculation#28704
Merged
Cal-L merged 4 commits intorelease/7.73.0from Apr 11, 2026
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We're experiencing an issue where the SafeAreaView top padding gets
recalculated upon component mount, which results in bad UI. This PR
reduces the blast radius of the changes by consolidating all
SafeAreaView imports to
react-native-safe-area-context. We then createa shim for the module, which handles applying top insets via style
instead. Changes also includes:
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Touches SafeAreaView usage across many screens, so incorrect
inset/edge handling could cause widespread layout regressions on
iOS/Android despite being mostly mechanical changes.
Overview
Standardizes
SafeAreaViewusage by switching many components fromreact-nativetoreact-native-safe-area-context(including addingexplicit
edgesin a few places) to avoid incorrect top-insetrecalculation on mount.
Refactors navigation/header configuration for
DeFiProtocolPositionDetailsby movingsetOptionslogic out of thecomponent and into
MainNavigatoroptions viagetDeFiProtocolPositionDetailsNavbarOptions(now explicitly setsheaderShown: true).Cleans up tests by removing per-file safe-area mocks in favor of the
centralized jest mock in
testSetupView.js, and updatessnapshots/expectations accordingly.
Reviewed by Cursor Bugbot for commit
f88a0cf. Bugbot is set up for automated
code reviews on this repo. Configure
here.