fix: show feedback in Quick Buy for unsupported Tron assets (TSA-659)

[xavier-brochard]

Description

Attempting a Quick Buy of a TRC-20 asset like HTX (Tron) left the Buy button permanently disabled with no error shown. Root cause: a gap between two support checks —

1. useQuickBuySetup treats any chain passing isNonEvmChainId as supported, and @metamask/bridge-controller returns true for Tron (tron:728126428), so the "unsupported chain" message never rendered.
2. But non-native destination tokens must resolve via useAssetMetadata, which only accepts Solana base58 or EVM hex addresses. A Tron base58 address fails both, so the destination token stays undefined forever — quotes are never requested, no error state is ever set, and the Buy button stays disabled via !destToken with zero feedback.

This PR:

• Primary gate: useQuickBuySetup now marks non-native assets on non-EVM chains other than Solana (e.g. TRC-20 tokens) as unsupported, so the existing "This chain is not supported for Quick Buy yet" message renders. Native non-EVM assets (TRX, SOL, BTC) keep working via the native-asset registry.
• Defensive surfacing: a new isDestTokenUnavailable flag covers the case where setup settles on a supported chain but no destination token resolves (metadata API empty/failed); the sheet shows a new localized message ("This token is not available for Quick Buy right now") instead of an inert buy flow.

Also fixes TSA-658 (duplicate ticket).

Jira: TSA-659

Changelog

CHANGELOG entry: Fixed the Quick Buy sheet showing a permanently disabled Buy button with no feedback for unsupported assets such as TRC-20 tokens on Tron

Related issues

Fixes: #31420

Manual testing steps

Feature: Quick Buy feedback for unsupported assets

  Scenario: user opens Quick Buy for a TRC-20 token
    Given the user navigates to the token details page of HTX on Tron

    When the user opens the Quick Buy sheet
    Then a "This chain is not supported for Quick Buy yet" message is shown
    And the Buy button is disabled

  Scenario: destination token fails to resolve on a supported chain
    Given the user opens Quick Buy for a token whose metadata cannot be fetched

    When the setup settles without a destination token
    Then a "This token is not available for Quick Buy right now" message is shown

  Scenario: supported assets still work
    Given the user opens Quick Buy for USDC on Base
    Then the buy flow behaves as before (quotes load, button enables)

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePerps, SmokePredictions, SmokeSwap, SmokeWalletPlatform, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 72%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR makes changes to:

1. QuickBuy flow (SocialLeaderboard/TraderPositionView): Adds isDestTokenUnavailable state, tokenDecimals/tokenImage to QuickBuyTarget type, and a new error message for when token metadata can't be resolved. This is the QuickBuy sheet used in Perps and Predictions trading flows. → SmokePerps, SmokePredictions

2. Bridge/useAssetMetadata: Adds Tron address detection (isTronAddress) to the asset metadata hook, and Tron chain support (isTronChainId) to the toAssetId utility. This affects how bridge/swap resolves token metadata. → SmokeSwap

3. AssetDetailsQuickBuy: Passes pre-resolved token metadata (decimals, image) from the asset details page to QuickBuy, avoiding a metadata re-fetch. This is used in TokenDetails and MarketInsightsView. → SmokeWalletPlatform (Trending/token details)

4. Localization: New string token_unavailable for QuickBuy sheet.

Per tag descriptions:

• SmokePerps: QuickBuy is the Add Funds flow entry point for Perps; changes to QuickBuy logic directly affect this. Also requires SmokeWalletPlatform (Trending section) and SmokeConfirmations (on-chain transactions).
• SmokePredictions: QuickBuy is used in Predictions flows; also requires SmokeWalletPlatform and SmokeConfirmations.
• SmokeSwap: Bridge asset metadata changes affect swap quote fetching and token resolution.
• SmokeConfirmations: Required when selecting SmokePerps, SmokePredictions, and SmokeSwap per their tag descriptions.
• SmokeWalletPlatform: Required when selecting SmokePerps and SmokePredictions (Trending section).

No E2E spec files directly test QuickBuy, but the functional changes to the QuickBuy controller, setup hook, and asset metadata are significant enough to warrant running the related smoke tests. Confidence is moderate (72) because there are no direct E2E tests for QuickBuy, so the impact is assessed indirectly through the feature areas these components belong to.

Performance Test Selection:
The changes are focused on QuickBuy logic (token metadata resolution, error state handling) and Bridge asset metadata (Tron address support). These are functional correctness fixes rather than performance-sensitive changes. No performance test scenarios (account list rendering, onboarding, login, swaps timing, app launch, asset loading, predict markets, perps trading) are directly impacted by these changes. The QuickBuy flow changes add a new state flag and bypass a metadata fetch when data is already available (which could marginally improve performance), but this is not significant enough to warrant performance test runs.

View GitHub Actions results