Skip to content

Add vLLM-metax vllm metax cmake presets validate compiler #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghangz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add vLLM-metax vllm metax cmake presets validate compiler #308

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8473c93
Validate CUDA compiler path in CMake presets
ghangz Jun 30, 2026
4b9a346
Require CUDA compiler path to be a file
ghangz Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/tools/test_generate_cmake_presets_validate_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import pytest

import tools.generate_cmake_presets as presets


def test_generate_presets_rejects_missing_cuda_compiler(monkeypatch):
monkeypatch.setattr(presets, "CUDA_HOME", None)
monkeypatch.setattr(presets, "which", lambda name: None)
monkeypatch.setattr("builtins.input", lambda prompt: "/missing/nvcc")

with pytest.raises(FileNotFoundError, match="/missing/nvcc"):
presets.generate_presets(force_overwrite=True)
2 changes: 2 additions & 0 deletions tools/generate_cmake_presets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ def generate_presets(output_path="CMakeUserPresets.json", force_overwrite=False)
"path to nvcc (e.g., /usr/local/cuda/bin/nvcc): "
)
nvcc_path = nvcc_path_input.strip()
if not nvcc_path or not os.path.exists(nvcc_path):
raise FileNotFoundError(f"CUDA compiler not found: {nvcc_path}")

@gemini-code-assist gemini-code-assist Bot Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using os.path.exists only checks if the path exists, which could be True even if the user accidentally provides a directory path (e.g., /usr/local/cuda/bin/) instead of the actual compiler executable. To prevent CMake from failing later with a cryptic error, use os.path.isfile to ensure the path points to a file.

Suggested change
if not nvcc_path or not os.path.exists(nvcc_path):
raise FileNotFoundError(f"CUDA compiler not found: {nvcc_path}")
if not nvcc_path or not os.path.isfile(nvcc_path):
raise FileNotFoundError(f"CUDA compiler not found: {nvcc_path}")

print(f"Using NVCC path: {nvcc_path}")

# Detect Python executable
Expand Down