feat: add support for commitDate and commitSha in packages#545
Draft
lafrenierejm wants to merge 3 commits intoMic92:mainfrom
Draft
feat: add support for commitDate and commitSha in packages#545lafrenierejm wants to merge 3 commits intoMic92:mainfrom
lafrenierejm wants to merge 3 commits intoMic92:mainfrom
Conversation
Contributor
Author
|
The test 4 failure is baffling. The failure is the "Gradle build daemon disappeared unexpectedly". I'm not sure how the changes in this PR could have caused Gradle to crash… The test 7 failure seems like a pre-existing issue likely caused by policy changes made server-side at gitlab.gnome.org. |
Mic92
force-pushed
the
commit-sha-and-date
branch
from
f5893a8 to
5cb0e21
Compare
Owner
|
pre-existing issues have been fixed in main. |
lafrenierejm
force-pushed
the
commit-sha-and-date
branch
5 times, most recently
from
d746fd5 to
74003ad
Compare
lafrenierejm
force-pushed
the
commit-sha-and-date
branch
from
74003ad to
198a66f
Compare
Enables nix-update to track and update commitDate and commitSha fields in package definitions. This is particularly useful for Go CLI modules, where it is common to embed the commit SHA and date in the binary via ldflags "-X main.commit" and "-X main.date", respectively. When updating packages, commit dates are normalized to UTC and formatted with the "Z" suffix for consistency across providers.
GitHub requires a series of API calls to retrieve the information about a tag's corresponding commit.
lafrenierejm
force-pushed
the
commit-sha-and-date
branch
from
198a66f to
a92bb87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables nix-update to track and update commitDate and commitSha fields in package definitions. All version providers (GitHub, GitLab, Gitea, Bitbucket, SourceHut) parse commit dates from their APIs.
This is particularly useful for Go CLI modules, where it is common to embed the commit date and SHA in the binary via ldflags "-X main.commit" and "-X main.date", respectively.
When updating packages, commit dates are normalized to UTC and formatted with the "Z" suffix for consistency across providers.