fix(metrics): add GPU detection fields to /metrics endpoint (Issue #111) - #115
Merged
Conversation
Michael-A-Kuykendall
force-pushed
the
fix/issue-111-gpu-metrics
branch
from
October 13, 2025 13:07
e23fc9d to
62f7d22
Compare
- Add gpu_detected boolean field to JSON response - Add gpu_vendor field (nvidia/amd/intel or null) - Implement detect_gpu(), get_gpu_vendor() functions - Add GPU vendor detection: nvidia-smi, rocm-smi, wmic queries - Comprehensive test coverage for GPU detection functionality - Resolves Issue #111: GPU metrics missing from /metrics endpoint 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com>
- Remove trailing whitespace in server.rs - Apply cargo fmt fixes across codebase - Ensure CI formatting checks pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com>
- Fix field_reassign_with_default in anthropic_compat.rs - Remove needless_borrows_for_generic_args in server.rs - Add allow(dead_code) attributes to placeholder memory utilities - All clippy lints now pass with -D warnings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com>
Michael-A-Kuykendall
force-pushed
the
fix/issue-111-gpu-metrics
branch
from
October 13, 2025 13:35
f0a5345 to
d7d3701
Compare
Michael-A-Kuykendall
added a commit
that referenced
this pull request
Oct 13, 2025
…) (#115) * fix(metrics): add GPU detection fields to /metrics endpoint (Issue #111) - Add gpu_detected boolean field to JSON response - Add gpu_vendor field (nvidia/amd/intel or null) - Implement detect_gpu(), get_gpu_vendor() functions - Add GPU vendor detection: nvidia-smi, rocm-smi, wmic queries - Comprehensive test coverage for GPU detection functionality - Resolves Issue #111: GPU metrics missing from /metrics endpoint 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com> * fix: resolve formatting issues for CI compliance - Remove trailing whitespace in server.rs - Apply cargo fmt fixes across codebase - Ensure CI formatting checks pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com> * fix: resolve clippy warnings for CI compliance - Fix field_reassign_with_default in anthropic_compat.rs - Remove needless_borrows_for_generic_args in server.rs - Add allow(dead_code) attributes to placeholder memory utilities - All clippy lints now pass with -D warnings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com> --------- Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com> Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com>
Michael-A-Kuykendall
added a commit
that referenced
this pull request
Dec 19, 2025
…) (#115) * fix(metrics): add GPU detection fields to /metrics endpoint (Issue #111) - Add gpu_detected boolean field to JSON response - Add gpu_vendor field (nvidia/amd/intel or null) - Implement detect_gpu(), get_gpu_vendor() functions - Add GPU vendor detection: nvidia-smi, rocm-smi, wmic queries - Comprehensive test coverage for GPU detection functionality - Resolves Issue #111: GPU metrics missing from /metrics endpoint 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com> * fix: resolve formatting issues for CI compliance - Remove trailing whitespace in server.rs - Apply cargo fmt fixes across codebase - Ensure CI formatting checks pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com> * fix: resolve clippy warnings for CI compliance - Fix field_reassign_with_default in anthropic_compat.rs - Remove needless_borrows_for_generic_args in server.rs - Add allow(dead_code) attributes to placeholder memory utilities - All clippy lints now pass with -D warnings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com> --------- Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpu_detectedboolean field to /metrics endpoint JSON responsegpu_vendorfield returning nvidia/amd/intel or nullTechnical Implementation
detect_gpu(): Multi-vendor detection using nvidia-smi, rocm-smi, wmicget_gpu_vendor(): Returns detected vendor string or nullTest Coverage
test_gpu_detection_functions(): Core detection logictest_nvidia_detection(),test_amd_detection(),test_intel_detection(): Individual vendor teststest_metrics_endpoint_gpu_fields(): Integration test for /metrics endpointChanges
🤖 Generated with Claude Code