fix(distribution): resolve MLX support missing from release pipeline (Issue #114) - #118
Closed
Michael-A-Kuykendall wants to merge 3 commits into
Closed
fix(distribution): resolve MLX support missing from release pipeline (Issue #114)#118Michael-A-Kuykendall wants to merge 3 commits into
Michael-A-Kuykendall wants to merge 3 commits into
Conversation
…(Issue #114) 🔧 **Root Cause Fixed**: Release workflow now builds macOS binaries with MLX features **Primary Changes:** - Update release workflow to build macOS binaries with `--features "huggingface,llama,mlx"` - Both Apple Silicon and Intel Mac binaries now include MLX support by default - Resolves core issue where distributed binaries lacked MLX despite source code support 📚 **Enhanced Documentation:** - Add platform-specific installation table with clear MLX instructions - Update quick start to recommend MLX for Apple Silicon users - Add verification commands (`shimmy gpu-info | grep -i mlx`) - Document distribution channels and feature differences 🧪 **Comprehensive Testing:** - Add distribution validation test suite (`tests/distribution_validation_test.rs`) - Test MLX installation commands, feature flags, and documentation - Validate release workflow includes MLX features - Platform-specific compilation tests for macOS 📦 **Homebrew Formula Updates:** - Update formula generation script to note MLX support in Apple Silicon binaries - Improve distribution documentation **Files Changed:** - `.github/workflows/release.yml`: Add MLX features to macOS builds - `README.md`: Platform-specific installation, verification instructions - `scripts/generate-homebrew-formula.sh`: MLX support documentation - `scripts/test-mlx-installation.sh`: MLX installation validation script - `tests/distribution_validation_test.rs`: Comprehensive distribution tests **User Impact:** ✅ Future releases (v1.7.4+) will include MLX in macOS binaries automatically ✅ Clear installation instructions for all platforms ✅ Users can verify MLX support with `shimmy gpu-info` ✅ No more "resolved but still broken" user experience Resolves Issue #114: Distribution pipeline failures for MLX support 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…into fix/issue-114-distribution-pipeline Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com>
Signed-off-by: Michael A. Kuykendall <michaelallenkuykendall@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the root cause of Issue #114: MLX support missing from release binaries. Updates release workflow to build macOS binaries with MLX features enabled and enhances documentation with platform-specific installation instructions.
Problem Analysis
Users reported that MLX support worked in source code but was missing from distribution channels:
Root Cause: Release workflow built macOS binaries with default features only, excluding MLX.
Solution Implemented
Release Pipeline Fix (Primary)
Updated .github/workflows/release.yml to build macOS binaries with MLX features:
Enhanced Documentation
Validation Testing
Impact
Starting with the next release (v1.7.4), macOS users will get MLX support automatically in GitHub releases. Clear documentation prevents user confusion about installation options.
Resolves Issue #114: Distribution pipeline failures for MLX support