Fix Issue #140: GGML Assert Batch Size Failure with Large Prompts - #158
Merged
Merged
Conversation
Michael-A-Kuykendall
added a commit
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the GGML assert failure when processing large prompts that exceed the hardcoded batch size limit.
Problem
Issue #140 reported GGML_ASSERT(n_tokens_all <= cparams.n_batch) failures when processing large prompts, particularly with DeepSeek-R1 models that have extensive system messages.
Root Cause
The batch size was hardcoded to 2048 tokens, causing assertion failures when context length exceeded this limit.
Solution
Implemented adaptive batch size calculation that scales based on context length:
Changes
calculate_adaptive_batch_size()method insrc/engine/llama.rstests/regression/issue_140_ggml_assert_batch_size.rsTesting
Impact
This fix prevents server crashes when processing large prompts while maintaining memory efficiency through adaptive sizing.