Use Vite instead of CRA#2476
Open
aflatter wants to merge 2 commits into
Open
Conversation
Author
|
@pabera I set up the Docker environment as per the docs and fixed the port allocation. Marked the PR as ready for review to trigger the CI. Let me know if there's anything else I should check. |
Collaborator
|
@aflatter could you fix the merge conflict in src/webapp/src/components/Settings/autohotspot.js? |
Author
I’ll try to find some time today |
Author
I rebased the branch and that fixed the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was curious about replacing CRA (which is not being worked on anymore) with Vite (which is probably the most direct replacement).
Notes:
eslintis configured tol run as part of the development server (as in CRA). Issues are displayed using thecheckerplugin..jsxas that's the easiest way to make them work with Vite.Todos:
run_rebuild.shstill behaves as intended.