Skip to content

Use Vite instead of CRA#2476

Open
aflatter wants to merge 2 commits into
MiczFlor:future3/developfrom
aflatter:vitejs
Open

Use Vite instead of CRA#2476
aflatter wants to merge 2 commits into
MiczFlor:future3/developfrom
aflatter:vitejs

Conversation

@aflatter

@aflatter aflatter commented Dec 30, 2024

Copy link
Copy Markdown

I was curious about replacing CRA (which is not being worked on anymore) with Vite (which is probably the most direct replacement).

Notes:

  • eslint is configured tol run as part of the development server (as in CRA). Issues are displayed using the checker plugin.
  • All JS files that contain JSX have been renamed to .jsx as that's the easiest way to make them work with Vite.
  • I decided to go with SWC instead of Babel. Who doesn't like more efficient builds?
  • There don't seem to be any tests currently, so I have not integrated a testing setup.

Todos:

  • Make sure the CI passes
  • Make sure the run_rebuild.sh still behaves as intended.

@aflatter aflatter changed the base branch from develop to future3/develop December 30, 2024 22:34
@pabera pabera added the future3 Relates to future3 development label Dec 31, 2024
@pabera pabera added this to the v3.7 milestone Dec 31, 2024
@pabera pabera self-requested a review December 31, 2024 07:32
@aflatter aflatter marked this pull request as ready for review January 2, 2025 20:29
@aflatter

aflatter commented Jan 2, 2025

Copy link
Copy Markdown
Author

@pabera I set up the Docker environment as per the docs and fixed the port allocation. Marked the PR as ready for review to trigger the CI. Let me know if there's anything else I should check.

@s-martin

s-martin commented Feb 4, 2025

Copy link
Copy Markdown
Collaborator

@aflatter could you fix the merge conflict in src/webapp/src/components/Settings/autohotspot.js?

@aflatter

aflatter commented Feb 5, 2025

Copy link
Copy Markdown
Author

@aflatter could you fix the merge conflict in src/webapp/src/components/Settings/autohotspot.js?

I’ll try to find some time today

@aflatter

aflatter commented Feb 5, 2025

Copy link
Copy Markdown
Author

@aflatter could you fix the merge conflict in src/webapp/src/components/Settings/autohotspot.js?

I rebased the branch and that fixed the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

future3 Relates to future3 development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants