Fix rpi-lgpio installation on non-ARM systems#2558
Conversation
- Added platform_machine condition to rpi-lgpio in requirements.txt - Prevents installation on non-Raspberry Pi systems
|
Hi, the phoniebox software still supports the Pi1 Model. For this the architecture is "armv6l". This should also be added. |
|
Is this PR still necessary with #2568? |
# Conflicts: # requirements.txt
Pull Request Test Coverage Report for Build 19716136597Details
💛 - Coveralls |
|
@s-martin From my point of view it is still required, otherwise the Dockerfile When building the Dockerfile, I get the following error:
To make both use cases possible, I extended the pull request. Docker is only needed for development (e.g. for web development), not for the Pi. |
|
it well fixed my Docker setup thank you |
@AlvinSchiller i think your comment was incorporated, could you check, if you can approve? |
This update restricts the installation of
rpi-lgpioto Raspberry Pi architectures only (armv7loraarch64) using environment markers inrequirements.txt.Previously, the dependency caused installation errors on x86 or other non-ARM hosts, which resulted in failed Docker builds. With this change applied, the following command should no longer fail: