Fix: workflow repository name configurable via GIT_REPO_NAME#2658
Open
MateoGreil wants to merge 1 commit into
Open
Fix: workflow repository name configurable via GIT_REPO_NAME#2658MateoGreil wants to merge 1 commit into
MateoGreil wants to merge 1 commit into
Conversation
The install script hard-coded the GitHub repository name as RPi-Jukebox-RFID when building the source download URL. Installing from a fork whose repository was renamed therefore produced a 404, the empty tarball broke 'tar xz' and the install aborted with 'Couldn't find git download.' Allow GIT_REPO_NAME to be overridden (defaulting to RPi-Jukebox-RFID) and pass it through the CI install-script tests from the repository name, so the suite works on renamed forks.
Author
|
I can't make run again the CI, but the actual fails looks like coming from a unavailable services. I guess it will success after a re-run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Here is a little fix on workflow, for fork repo.
The install script hard-coded the GitHub repository name as RPi-Jukebox-RFID when building the source download URL. Installing from a fork whose repository was renamed therefore produced a 404, the empty tarball broke 'tar xz' and the install aborted with 'Couldn't find git download.'
Allow GIT_REPO_NAME to be overridden (defaulting to RPi-Jukebox-RFID) and pass it through the CI install-script tests from the repository name, so the suite works on renamed forks.
Workflow error before: https://github.com/MateoGreil/phoniebox/actions/runs/27874252323
Workflow running now: https://github.com/MateoGreil/phoniebox/actions/runs/27875331806