Deprecate ParametricExpressionSpec in favor of TemplateExpressionSpec#920
Merged
Conversation
|
Thanks Miles. Apologies, my entire set up is now directly in Julia, I'll struggle to get this tested in a timely manner. Are you planning a similar warning in SR.jl? |
Owner
Author
|
No worries! And yes; will put it in Julia too with a deprecation warning there. Just happened to write it on the Python side first |
MilesCranmer
force-pushed
the
deprecate-parametric-expression
branch
from
922c087 to
95ff874
Compare
Pull Request Test Coverage Report for Build 15033004687Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to give a helpful warning message to the user for how to upgrade to template expressions.
Suggested by @gm89uk as he found the performance was much better. So there's not much of a point in having a separate class anymore when template expressions are just better.
Care to take a look at the PR and let me know what you think?