fix: compat with python 3.8 by removing beartype#935
Merged
Conversation
48e617e to
3bd5fc8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #935 +/- ##
==========================================
- Coverage 93.77% 93.54% -0.24%
==========================================
Files 21 21
Lines 1559 1565 +6
==========================================
+ Hits 1462 1464 +2
- Misses 97 101 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beartype seems to have some builds on conda-forge that are incompatible with older python. These can't be removed without significant effort. But at the end of the day, we were only using the beartype import for one single type (
typing.List, since Python will eventually deprecate this). Therefore, in order to keep compatibility with old versions, I need to remove beartype as a mandatory requirement. It turns out thattyping_extensionsalso has aListso I'll just do that.Regardless, beartype is still used during testing.