fix(ui): forgot password link in extension + remove em dashes from UI copy#38
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
UI Text Updates client/src/app/auth/page.tsx, client/src/app/bookmarklet/BookmarkletSaver.tsx, client/src/components/DashboardClient.tsx, client/src/components/SaveUrlForm.tsx |
Punctuation standardization: em-dashes replaced with periods in error and status messages; "Save from any page —" rephrased to "Save from any page using the". |
Extension Popup UI & Styling extension/popup.html, extension/popup.css |
Added "Forgot password?" link in authentication view with security attributes; new CSS rules for .forgot-link container centering and margin; nested a element styling with default font size, muted color, and hover state; color value normalized to lowercase. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
- PR
#37: Implements the full forgot password flow with reset-password page and password reset functionality in auth components; directly complements the forgot password link addition in this PR. - PR
#22: Modifies extension popup UI structure and styling (popup.html and popup.css), overlaps with the extension popup changes introduced here. - PR
#35: Adds the "Surprise me" feature and initial "No bookmarks yet" message in DashboardClient.tsx; this PR updates the same message text.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and concisely summarizes the main changes: adding a forgot password link to the extension and removing em dashes from UI copy. |
| Description check | ✅ Passed | The PR description covers the main changes with clear sections, includes the required checklist template, and addresses the objectives. One checklist item (manual browser testing) remains unchecked, which is acceptable for a bug fix of this scope. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/extension-forgot-password
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
extension/popup.css (1)
65-73:⚠️ Potential issue | 🟠 MajorMigrate popup.css styling to Tailwind CSS v4 utilities.
The
.manage-linkand.forgot-linkCSS rules conflict with the repository guideline requiring Tailwind CSS v4 for styling. Replace the custom selectors inextension/popup.csswith utility classes applied directly in the HTML markup (extension/popup.html), then remove the now-unused CSS rules.Per coding guidelines:
**/*.{tsx,ts,css}: Use Tailwind CSS v4 for styling🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@extension/popup.css` around lines 65 - 73, The .manage-link and .forgot-link rules in extension/popup.css must be removed and replaced with Tailwind CSS v4 utility classes applied in extension/popup.html; find elements using the classes "manage-link" and "forgot-link" in popup.html and replace their class names with equivalent Tailwind utilities (e.g., block, text-center, text-[color], text-sm, no-underline, mt-1, mb-3) to preserve layout and spacing, then delete the .manage-link and .forgot-link rules from popup.css so the stylesheet no longer contains those custom selectors.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@extension/popup.css`:
- Around line 65-73: The .manage-link and .forgot-link rules in
extension/popup.css must be removed and replaced with Tailwind CSS v4 utility
classes applied in extension/popup.html; find elements using the classes
"manage-link" and "forgot-link" in popup.html and replace their class names with
equivalent Tailwind utilities (e.g., block, text-center, text-[color], text-sm,
no-underline, mt-1, mb-3) to preserve layout and spacing, then delete the
.manage-link and .forgot-link rules from popup.css so the stylesheet no longer
contains those custom selectors.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: d6ad4386-9528-4f19-aa34-7f9fe4655bb1
⛔ Files ignored due to path filters (2)
CLAUDE.mdis excluded by none and included by nonerecall-extension-v1.0.0.zipis excluded by!**/*.zipand included by none
📒 Files selected for processing (6)
client/src/app/auth/page.tsxclient/src/app/bookmarklet/BookmarkletSaver.tsxclient/src/components/DashboardClient.tsxclient/src/components/SaveUrlForm.tsxextension/popup.cssextension/popup.html
1 participant
Summary
Type of change
Checklist
npm run build)npx tsc --noEmit)npm run lint)🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Style