Skip to content

GEOPY-2884: Change data groups saved for MVI as requested by users#146

Merged
domfournier merged 1 commit into
release/GA_4.8from
GEOPY-2884
May 28, 2026
Merged

GEOPY-2884: Change data groups saved for MVI as requested by users#146
domfournier merged 1 commit into
release/GA_4.8from
GEOPY-2884

Conversation

@domfournier

@domfournier domfournier commented May 28, 2026

Copy link
Copy Markdown

GEOPY-2884 - Change data groups saved for MVI as requested by users

Copilot AI review requested due to automatic review settings May 28, 2026 21:36
@github-actions github-actions Bot changed the title GEOPY-2884 GEOPY-2884: Change data groups saved for MVI as requested by users May 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new GeoH5-saving directive intended to change how inversion model outputs are grouped (for user-requested MVI workflows), and includes a small readability-only formatting change in the vector-model directive.

Changes:

  • Reformats the MVI switching conditional in VectorInversion.endIter for readability (no logic change).
  • Adds a new SaveModelGroup directive that groups saved FloatData into property groups keyed by component name.
  • Exposes SaveModelGroup from simpeg.directives via __init__.py.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
simpeg/directives/_vector_models.py Minor formatting/readability update to the MVI coordinate-switching condition.
simpeg/directives/_save_geoh5.py Adds SaveModelGroup directive to control property-group naming/grouping.
simpeg/directives/__init__.py Re-exports SaveModelGroup from the directives package.
Comments suppressed due to low confidence (1)

simpeg/directives/init.py:133

  • PR description indicates behavior change for “data groups saved for MVI”, but within this repo the new SaveModelGroup is only defined/exported and not referenced anywhere else. As-is, no grouping behavior will change unless downstream code/workflows switch to this directive. Either update the PR description to reflect that this is a new optional directive, or include the change that wires it into the MVI saving pipeline (if intended).
from ._save_geoh5 import (
    BaseSaveGeoH5,
    SaveDataGeoH5,
    SaveLogFilesGeoH5,
    SaveLPModelGroup,
    SaveModelGroup,
    SaveModelGeoH5,
    SavePGIModel,
    SavePropertyGroup,
    SaveSensitivityGeoH5,
)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +528 to +536
def get_names(
self, component: str, channel: int | None, iteration: int
) -> tuple[str, str]:
"""
Format the data and property_group name.
"""
channel_name, _ = super().get_names(component, channel, iteration)

return channel_name, component
Comment thread simpeg/directives/_save_geoh5.py
@domfournier domfournier merged commit 67d3cf8 into release/GA_4.8 May 28, 2026
13 checks passed
@domfournier domfournier deleted the GEOPY-2884 branch May 28, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants