GEOPY-2910: Reduce chunking of sensitivities for TEM inversions#152
Merged
Conversation
GEOPY-2910: Reduce chunking of sensitivities for TEM inversions
There was a problem hiding this comment.
Pull request overview
This PR updates the Dask-based TDEM sensitivity assembly to reduce sensitivity “chunking” by stacking field-derivative solves across each parallel block, aiming to lower overhead and improve inversion performance/memory behavior.
Changes:
- Disables
get_parallel_blocks(..., optimize=True)re-splitting to avoid extra block/chunk fragmentation. - Refactors
get_field_deriv_blockto build a single denseATinv_df_duT_varray per block (instead of per-chunk lists) and solve in a stacked call. - Updates
compute_rowsto slice the new per-block derivative array using a running column offset (colm_count).
Comments suppressed due to low confidence (1)
simpeg/dask/electromagnetics/time_domain/simulation.py:482
- When
local_indis empty, this branchcontinues without advancingcolm_count. Since later iterations slicefield_derivs[block_ind]usingcolm_count, subsequent chunks will be misaligned (wrong columns used for derivatives), producing incorrect sensitivity rows.
if len(local_ind) < 1:
row_block = np.zeros(
(len(ind_array[1]), simulation.model.size), dtype=np.float32
)
rows.append(row_block)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2910 - Reduce chunking of sensitivities for TEM inversions