Open
Conversation
Based on the following commit: ca9dcfb
Owner
|
@kawata-yuya This looks like a nice improvement. I'll review it properly as soon as I get some time. I appreciate your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's changed
This PR supports Docker compose to improve build and run container processes.
By setting the virtualenv path to
/opt/venv, I resolved the issue whereuv virtualenvwas copied to the host when the workspace was mounted./dev_ws/python_simple_mppi/.venvto/opt/venv.venvfrom being created in the host machine's workspace during mounting, keeping the host environment clean.Changes in the Docker startup process
Before
After