fix: remount expanded file diff when content changes#799
Merged
Conversation
VirtualizedFileDiff caches its fileDiff on first hydration (this.fileDiff ??= fileDiff), so a refetch with changed content never renders fresh lines. Keying FileDiffRenderer by the file's review content hash forces a remount when the underlying diff changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VirtualizedFileDiffcaches itsfileDiffon first hydration (this.fileDiff ??= fileDiff), so refetching a file with changed content never re-renders updated lines while a diff row stays expanded.FileDiffRendererbyreviewKeyByFile(content hash), forcing a remount when the underlying diff content changes, instead of reusing the stale cached instance.