Skip to content

Adapt backend search to complex filter - #48

Merged
Wunderwaffel merged 7 commits into
mainfrom
backend/complex-search-filter
Jan 30, 2026
Merged

Adapt backend search to complex filter#48
Wunderwaffel merged 7 commits into
mainfrom
backend/complex-search-filter

Conversation

@MoSchmidt

Copy link
Copy Markdown
Owner

No description provided.

@MoSchmidt MoSchmidt self-assigned this Jan 27, 2026
Copilot AI review requested due to automatic review settings January 27, 2026 10:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for an “advanced search filter” (year range + nested AND/OR text conditions) across backend search endpoints and propagates it through the generated OpenAPI schema/client and frontend search flow.

Changes:

  • Introduces AdvancedSearchFilter / ConditionGroup / TextCondition DTOs and wires them through search request/handling.
  • Applies advanced filters in the vector search repository query (year bounds + title/abstract contains/not-contains).
  • Updates OpenAPI spec + regenerated TypeScript client and hooks the new filter into the frontend search calls.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
openapi/openapi.json Documents the new advanced filter schemas and updated search endpoint descriptions/parameters.
frontend/src/services/search.ts Adds advanced filter support to text/PDF search service calls.
frontend/src/pages/SearchPage.vue Passes advanced options through to the updated search service functions.
frontend/src/api/models/validation-error.ts Updates validation error loc type import to the regenerated model.
frontend/src/api/models/text-condition.ts Adds generated model for text conditions.
frontend/src/api/models/search-request.ts Adds filter to SearchRequest type.
frontend/src/api/models/index.ts Exports newly generated advanced-filter-related models.
frontend/src/api/models/condition-group.ts Adds generated model for condition groups.
frontend/src/api/models/condition-group-children-inner.ts Adds generated union type for recursive group/condition children.
frontend/src/api/models/advanced-search-filter.ts Adds generated model for the advanced search filter DTO.
frontend/src/api/common.ts Updates query param flattening and JSON serialization behavior in the generated client.
frontend/src/api/apis/users-api.ts Removes now-nonexistent helper import from generated API.
frontend/src/api/apis/search-api.ts Adds filter form field parameter for PDF search and updates generated docs/signatures.
frontend/src/api/apis/projects-api.ts Removes now-nonexistent helper import from generated API.
frontend/src/api/apis/paper-api.ts Removes now-nonexistent helper import from generated API.
frontend/src/api/apis/authentication-api.ts Removes now-nonexistent helper import from generated API.
frontend/src/api/.openapi-generator/VERSION Updates recorded OpenAPI generator version.
frontend/src/api/.openapi-generator/FILES Updates generated file manifest for new/removed models.
backend/app/services/search_service.py Threads search_filter through the search pipeline into the repository.
backend/app/schemas/search_dto.py Defines Pydantic DTOs for advanced filtering and adds them to SearchRequest.
backend/app/routes/search_routes.py Accepts/parses advanced filter for PDF search and passes it to the service layer.
backend/app/repositories/search_repository.py Implements SQLAlchemy clause generation for year/text-condition filters.
CLAUDE.md Adds repository guidance for Claude Code usage and project commands.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/src/services/search.ts
Comment thread backend/app/routes/search_routes.py Outdated
Comment thread frontend/src/api/common.ts
Comment thread backend/app/repositories/search_repository.py Outdated
Comment thread backend/app/schemas/search_dto.py
Comment thread frontend/src/api/apis/paper-api.ts
Comment thread frontend/src/api/apis/users-api.ts
Comment thread frontend/src/api/apis/search-api.ts
Comment thread frontend/src/api/apis/projects-api.ts
Comment thread frontend/src/api/apis/search-api.ts

@Wunderwaffel Wunderwaffel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Wunderwaffel
Wunderwaffel merged commit 4fddc99 into main Jan 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants