fix: replay compaction records on resume#617
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 191722d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfa03dc29f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue.
Problem
Resumed TUI sessions did not show historical compaction activity because compaction state was not projected as a replay record. This made completed or cancelled compactions disappear from the transcript after resume.
What changed
Verification
pnpm vitest run packages/agent-core/test/agent/resume.test.tspnpm vitest run apps/kimi-code/test/tui/message-replay.test.tspnpm --filter @moonshot-ai/agent-core run typecheckpnpm --filter @moonshot-ai/kimi-code run typecheckpnpm exec oxlint --type-aware packages/agent-core/src/rpc/resumed.ts packages/agent-core/src/agent/compaction/full.ts packages/agent-core/src/agent/context/index.ts packages/agent-core/src/agent/replay/index.ts apps/kimi-code/src/tui/types.ts apps/kimi-code/src/tui/kimi-tui.ts apps/kimi-code/src/tui/controllers/session-replay.ts packages/agent-core/test/agent/resume.test.ts apps/kimi-code/test/tui/message-replay.test.tsChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.