fix: cancel active turns during session shutdown#661
Merged
7Sageer merged 2 commits intoJun 11, 2026
Conversation
🦋 Changeset detectedLatest commit: 3a069a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This fixes a prompt-mode shutdown regression where foreground Bash processes could outlive
kimi -pwhen the CLI receivesSIGTERMorSIGHUP.Problem
Prompt-mode signal cleanup closed the harness, but session shutdown only stopped managed background tasks. If a foreground Bash tool was still running, the active turn was not canceled during
Session.close(), so the Bash tool never received the abort signal it uses to terminate the child process. Managed background Bash timeout timers also remained referenced, which could keepkimi -palive after the prompt completed.What changed
Session.close()before background-task shutdown, with a bounded wait and timeout warning.unref()managed background Bash timeout timers so they do not keep prompt mode alive.SIGHUPin prompt-mode termination cleanup, matching standard signal exit code129.SIGTERM/SIGHUPcleanup.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.