test: fix resume test assertions for compaction replay records#681
Merged
Conversation
|
commit: |
82c526f to
7009a8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test/agent/resume.test.ts中两个与 compaction 相关的断言(projects restored compactions into replay records和projects restored cancelled compactions into replay records)使用了toEqual严格匹配字面量对象,但ReplayBuilder.push会给所有 replay record 自动注入time字段(由AgentReplayRecord类型定义),导致断言失败。What changed
将这两个 compaction 的期望对象改用
expect.objectContaining包裹,与同一文件中 message 类型的断言方式保持一致,忽略由ReplayBuilder自动注入的time字段。