feat(kimi-code): refresh OAuth provider models before opening model picker#713
Merged
Conversation
…icker - call refreshOAuthProviderModels before /model picker opens\n- add scoped refreshAllProviderModels with 'oauth' and 'all' scopes\n- update tests for async picker rendering and OAuth-only refresh
🦋 Changeset detectedLatest commit: b0c0e02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the
/modelslash command refresh OAuth-backed provider models right before opening the model picker, so newly-available or changed OAuth models show up without forcing a full provider refresh. It introduces a scoped refresh mode so the picker can refresh only OAuth providers, and adds a short timeout so the UI stays responsive even if the refresh hangs.1. Refresh OAuth models before opening the model picker
Problem: The
/modelpicker could display stale model lists for OAuth providers because it did not refresh provider models before rendering.What was done:
handleModelCommandtoasyncand callrefreshOAuthProviderModels()before showing the picker.MODEL_PICKER_REFRESH_TIMEOUT_MS(2 s) helper so the picker still opens promptly even if the refresh is slow or fails.2. Scoped provider model refresh
Problem:
refreshAllProviderModelsalways refreshed every provider, which is unnecessary when the picker only needs OAuth provider data.What was done:
RefreshProviderScope = 'all' | 'oauth'andRefreshProviderOptionstorefresh-providers.ts.AuthFlowControllerwithrefreshOAuthProviderModels()(scope'oauth') and keptrefreshProviderModels()as'all'.'all'.3. Tests
What was done:
test/tui/utils/refresh-providers.test.tsfor OAuth-only refresh behavior.test/tui/kimi-tui-message-flow.test.tsto cover async model picker rendering after the refresh call.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs a doc update.make gen-changelogto update the changelog.