Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/acp-stop-reason-fallback.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@moonshot-ai/kimi-code": patch
---

Fallback ACP turn-end stop reason mapping to `end_turn` for unknown runtime values.
4 changes: 4 additions & 0 deletions packages/acp-adapter/src/events-map.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ export function assistantDeltaToSessionUpdate(
* belong on the JSON-RPC error channel). Returning `end_turn` keeps the
* client unblocked; the caller is expected to log the `error` payload
* separately so the failure is observable in the agent logs.
* Unknown runtime values also fall back to `end_turn` so a newer SDK
* reason cannot leak `undefined` onto the ACP wire.
*/
export function turnEndReasonToStopReason(reason: TurnEndReason): AcpStopReason {
switch (reason) {
Expand All @@ -65,6 +67,8 @@ export function turnEndReasonToStopReason(reason: TurnEndReason): AcpStopReason
return 'cancelled';
case 'failed':
return 'end_turn';
default:
return 'end_turn';
}
}

Expand Down
17 changes: 17 additions & 0 deletions packages/acp-adapter/test/events-map.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { describe, expect, it } from 'vitest';

import type { TurnEndReason } from '@moonshot-ai/kimi-code-sdk';

import { turnEndReasonToStopReason } from '../src/events-map';

describe('turnEndReasonToStopReason', () => {
it('maps known SDK turn-end reasons to ACP stop reasons', () => {
expect(turnEndReasonToStopReason('completed')).toBe('end_turn');
expect(turnEndReasonToStopReason('cancelled')).toBe('cancelled');
expect(turnEndReasonToStopReason('failed')).toBe('end_turn');
});

it('falls back to end_turn for unknown runtime reasons', () => {
expect(turnEndReasonToStopReason('interrupted' as TurnEndReason)).toBe('end_turn');
});
});