Port upstream improvements from superpowers - #42
Merged
Conversation
Port reliability, architecture, and documentation improvements: - Brainstorm server: validate owner PID at startup, fix EPERM handling, separate content/state directories for cleaner session management - stop-server.sh: graceful shutdown with SIGKILL fallback and verification - start-server.sh: content/state directory structure, Windows/Git Bash auto-foreground detection, portable shebang - Brainstorming SKILL: replace subagent spec review loop with inline self-review (validated upstream as more effective) - Add subagent context paragraphs to dispatching-parallel-agents and subagent-driven-development skills - visual-companion.md: update for content/state separation, add Windows platform instructions
RomarQ
requested review from
crystalin,
gabriel-hurtado and
timbrinded
as code owners
April 13, 2026 10:23
The agent receives screen_dir and state_dir from server output but stop-server.sh expects the parent session directory. Use dirname to derive it from state_dir rather than referencing an undefined variable.
SESSION_DIR is clear enough from context in the doc. The agent can derive it from the JSON example showing screen_dir and state_dir as children of the session directory.
RomarQ
changed the title
- Use 4-space indentation to match project shfmt config (-i 4 -ci) - Replace unused loop variable 'i' with '_' to fix SC2034
Fixes pre-existing markdownlint MD012 violation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#!/usr/bin/env bash), Windows/Git Bash auto-foreground detection