Skip to content
This repository was archived by the owner on Nov 7, 2023. It is now read-only.

fix: more reliable linking#312

Open
sentialx wants to merge 2 commits intoMrJake222:masterfrom
sentialx:linking
Open

fix: more reliable linking#312
sentialx wants to merge 2 commits intoMrJake222:masterfrom
sentialx:linking

Conversation

@sentialx
Copy link
Copy Markdown

Fixes issues with linking DHD or Transport Rings when a block position changes.

@MrJake222
Copy link
Copy Markdown
Owner

MrJake222 commented May 17, 2021

Your pull requests/commits/code could use some comments. So what's the deal with the linkId?

Edit: Is it used anywhere? I don't seem to find it's uses beside getters/setters/saving to NBT

@sentialx
Copy link
Copy Markdown
Author

Normally when you move the gate with DHD to a place where there is a DHD already, it tries to connect to the DHD regardless of its previous connection. linkId property is meant to solve that problem.

@MrJake222
Copy link
Copy Markdown
Owner

I'd never guessed that. Please add some comments (see how to create JavaDoc, basically start the multiline comment with /**) to the fields and methods using it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants