Fix/subscriptions auth improvements - #1321
Merged
aji70 merged 4 commits intoJun 28, 2026
Merged
Conversation
|
@josunday002 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Apply ThrottlerGuard at controller level and @Throttle decorators on all POST endpoints (checkout, validate, confirm, fail, cancel) to prevent abuse.
Cover login, register, requestChallenge, verifyChallenge endpoints with mocked AuthService and WalletAuthService. Tests verify delegation, validation, network mismatch handling, and error propagation.
Add typed DTOs for checkout request/response bodies (CreateCheckoutDto, ValidateBalanceDto, ConfirmSubscriptionDto, etc.) and wire them into controller with @apiresponse type references and detailed descriptions.
Add SubscriptionsExceptionFilter that normalizes all errors to a
consistent {statusCode, error, message, timestamp, path} shape.
Applied at controller level via @UseFilters.
josunday002
force-pushed
the
fix/subscriptions-auth-improvements
branch
from
June 28, 2026 06:36
1993b0b to
74ba625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1043
closes #1044
closes #1045
closes #1046
Backend module Subscriptions (subscriptions). Add rate limiting on write endpoints.
Backend module Subscriptions (subscriptions). Document endpoints in Swagger/OpenAPI.
Backend module Subscriptions (subscriptions). Return consistent error shape on failure.