Feat/subscriptions tests and pagination - #1323
Merged
aji70 merged 5 commits intoJun 28, 2026
Merged
Conversation
Cover addSubscription, renewSubscription, cancelSubscription, isSubscriber, getSubscription, createCheckout, getCheckout, confirmSubscription, getPlanSummary, getPriceBreakdown, validateBalance, getWalletStatus, getTransactionPreview, failCheckout, getFanDashboardSummary, getCompletedPayments, and assertNetworkMatch.
Cover ListSubscriptionsQueryDto, ListCreatorSubscribersQueryDto, SubscriptionStateQueryDto, SubscriptionIndexerEventDto, SetSpendingCapDto, and FanDashboardQueryDto with invalid inputs (missing fields, out-of-range values, invalid enums, format mismatches).
Add integration tests for GET /v1/subscriptions/me/subscription-state, GET /v1/subscriptions/me/list, POST /v1/subscriptions/cancel, and GET /v1/subscriptions/me/dashboard covering auth, pagination, and happy path flows.
Add GET /v1/subscriptions/me/dashboard endpoint with page/limit query params via FanDashboardQueryDto, wiring to the existing getFanDashboardSummary service method. Includes controller unit tests.
|
@martinzhames Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
martinzhames
force-pushed
the
feat/subscriptions-tests-and-pagination
branch
from
June 28, 2026 06:55
3858964 to
a9c55f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1040
closes #1039
closes #1041
closes #1042
Backend module Subscriptions (subscriptions). Add service unit tests for happy path.
Backend module Subscriptions (subscriptions). Add DTO validation tests for invalid input.
Backend module Subscriptions (subscriptions). Add e2e test for primary endpoint.