fix(earnings): replace admin() unwrap with typed NotInitialized error - #1498
Merged
aji70 merged 1 commit intoJul 24, 2026
Merged
Conversation
- Add Error::NotInitialized (code 2) to the earnings contract error enum. - admin() now returns the typed error via panic_with_error! instead of panicking on an unwrap() of empty instance storage when the contract has never been initialized. - Add test_admin_returns_not_initialized_before_init covering the uninitialized-view path via try_admin(). Closes MyFanss#1374
|
@priscaenoch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #1374
Earnings::admin()panicked with a rawunwrap()on empty instance storage when the contract had never been initialized, instead of returning a typed contract error. This surfaces as an opaque host panic rather than a decodable Soroban contract error for callers.Error::NotInitialized(code 2) to the earnings contract's#[contracterror]enum, appended after the existingAlreadyInitialized(code 1) per the "do not renumber existing variants" rule documented on the enum.admin()now uses.unwrap_or_else(|| panic_with_error!(&env, Error::NotInitialized)), mirroring the exact pattern already used bysubscription::MyfansContract::admin().test_admin_returns_not_initialized_before_init, which callstry_admin()on a freshly-registered, uninitialized contract and asserts the typed error is returned.Testing/validation performed
subscriptioncontract's identicaladmin()error-typing pattern for consistency.cargo test -p earnings,cargo fmt --check, or the wasm build locally. The change is a minimal, mechanical mirror of an existing, already-tested pattern insubscription::admin(), but please confirm CI (cargo test -p earnings) passes before merging.Issue
#1374