fix(backend): use SDK discriminated unions for simulate responses in … - #799
Merged
Merged
Conversation
…chain reader
- Extract retval via isSimulationError / isSimulationSuccess / isSimulationRestore
instead of accessing sim.result?.retval directly on the union type
- Add extractRetval() helper that narrows all three branches and returns a
typed { retval } | { error } result — no more unsafe property access
- Handle SimulateTransactionRestoreResponse (archived ledger entry) as a
transient error with a clear message so callers can retry after restoration
- Apply withRetry to readPlan and readPlanCount (previously missing, inconsistent)
- Deduplicate server/tx construction into makeServer() and buildTx() helpers
- Tests: subscription-chain-reader.service.spec.ts — 14 cases covering
success, error, restore, missing retval, and network rejection for all
four read methods
|
@Mimah97 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
aji70
added a commit
that referenced
this pull request
Apr 30, 2026
fix(backend): use SDK discriminated unions for simulate responses in …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…chain reader
closes Fix
subscription-chain-readersimulation typing #580