Skip to content

[CLEANUP] Tighten type annotations in AtRuleBlockListTest #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverklee merged 1 commit into from
Feb 28, 2026
Merged

[CLEANUP] Tighten type annotations in AtRuleBlockListTest #1555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions tests/CSSList/AtRuleBlockListTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
final class AtRuleBlockListTest extends TestCase
{
/**
* @return array<string, array{0: string}>
* @return array<non-empty-string, array{0: non-empty-string}>
*/
public static function provideMinWidthMediaRule(): array
{
Expand All @@ -28,7 +28,7 @@ public static function provideMinWidthMediaRule(): array
}

/**
* @return array<string, array{0: string}>
* @return array<non-empty-string, array{0: non-empty-string}>
*/
public static function provideSyntacticallyCorrectAtRule(): array
{
Expand Down Expand Up @@ -75,6 +75,8 @@ public static function provideSyntacticallyCorrectAtRule(): array
/**
* @test
*
* @param non-empty-string $css
*
* @dataProvider provideMinWidthMediaRule
*/
public function parsesRuleNameOfMediaQueries(string $css): void
Expand All @@ -89,6 +91,8 @@ public function parsesRuleNameOfMediaQueries(string $css): void
/**
* @test
*
* @param non-empty-string $css
*
* @dataProvider provideMinWidthMediaRule
*/
public function parsesArgumentsOfMediaQueries(string $css): void
Expand All @@ -103,6 +107,8 @@ public function parsesArgumentsOfMediaQueries(string $css): void
/**
* @test
*
* @param non-empty-string $css
*
* @dataProvider provideMinWidthMediaRule
* @dataProvider provideSyntacticallyCorrectAtRule
*/
Expand All @@ -114,7 +120,7 @@ public function parsesSyntacticallyCorrectAtRuleInStrictMode(string $css): void
}

/**
* @return array<string, array{0: string, 1: string, 2: string, 3: int}>
* @return array<non-empty-string, array{0: non-empty-string, 1: non-empty-string, 2: string, 3: int<0, max>}>
*/
public static function provideAtRuleParsingData(): array
{
Expand Down Expand Up @@ -159,7 +165,7 @@ public static function provideAtRuleParsingData(): array
}

/**
* @return array<string, array{0: string, 1: list<string>}>
* @return array<non-empty-string, array{0: non-empty-string, 1: non-empty-list<non-empty-string>}>
*/
public static function provideAtRuleRenderingData(): array
{
Expand All @@ -186,6 +192,10 @@ public static function provideAtRuleRenderingData(): array
/**
* @test
*
* @param non-empty-string $css
* @param non-empty-string $expectedName
* @param int<0, max> $expectedContentCount
*
* @dataProvider provideAtRuleParsingData
*/
public function parsesAtRuleBlockList(
Expand All @@ -208,7 +218,8 @@ public function parsesAtRuleBlockList(
*
* @dataProvider provideAtRuleRenderingData
*
* @param list<string> $expectedSubstrings
* @param non-empty-string $css
* @param non-empty-list<non-empty-string> $expectedSubstrings
*/
public function rendersAtRuleBlockListCorrectly(string $css, array $expectedSubstrings): void
{
Expand Down