[TASK] Also check Build/ with static code analysis#1609
Merged
oliverklee merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
oliverklee
added this to the
8.3.0 New features, bug fixes, and performance improvements milestone
oliverklee
added
the
developer-specific
|
coverage: 96.445%. remained the same — task/check-build into main |
oliverklee
force-pushed
the
task/check-build
branch
2 times, most recently
from
6f78d3b to
4d09f45
Compare
We now have PHP files in `Build/`, and we should check and autofix those as well. We omit these two tools: - PHPStan (as it cannot find the PHP-CS-Fixer classes from the PHAR) - PHPMD (as it only can check one directory)
oliverklee
force-pushed
the
task/check-build
branch
from
4d09f45 to
1be5882
Compare
JakeQZ
approved these changes
Apr 15, 2026
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
- PHPMD (as it only can check one directory)
Actually it can check multiple directories, from a comma-separated list on the command line, e.g. phpmd src,tests text config/phpmd.xml. We were previously only checking src; expanding the checking should be the scope of a separate PR.
Collaborator
Author
Ah, I see. Thanks! I think we don't need to - as far as code metrics are concerned, I think those are only relevant for the production code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have PHP files in
Build/, and we should check and autofix those as well.We omit these two tools: