Prune settled payout tree nodes#1092
Merged
Merged
Conversation
0xaslan
force-pushed
the
at/predict-open-items
branch
from
8cc297a to
8d9a1c0
Compare
0xaslan
force-pushed
the
at/predict-open-items
branch
from
8d9a1c0 to
839863a
Compare
…vidence-backed rules Scope: Predict cluster only (no deepbook-core changes); docs/skill files only, no Move source. Rule files: - move.md: rewrite Predict-Economics to static-floor knockout (drop terminal_floor_index / floor_index / time-varying-floor / opened_at_ms-in-id; static F, quantity - floor_shares, exact NAV = Sum qty*P - Sum min(qty*P,F), knock-out level, lambda buffer) -- verified at HEAD. Add: Open-Closed/irreversibility, loop-hoist preservation, guard-preservation across extraction, unbounded-permissionless-state-in-aggregation, owner-auth fallback for terminal exits, defer-and-carry; return-struct default + Data-Clump (2-3, not 4+); trust-boundary carve-out to non-redundancy; two-sided + recoverable safety bounds. - code-review.md: add loop-hoist regression check. - unit-tests.md: Rule 4 -> reachable-only + testability-as-design; Rule 15 -> fix dangling .redesign/BUGS_FOUND.md path to .claude/predict-review/OPEN-ITEMS.md. - CLAUDE.md: re-aim the Predict-economics gate at the current settled list; flag the journal as historical; separate NAV-supersession from the still-live D030 backing axis; state knockout. predict-audit skill (kept Predict-scoped): - SKILL.md/primer.md: fix scope to the 4 Predict-cluster packages (not deepbook core); migration out of scope. - primer.md/lens 01/defi-invariant-classes.md: reframe live-backing / aggregate-NAV to static Q-F + lambda / knock-out-level. - ownership-rules.md: R2 drops opened_at_ms; R5 adds the trust-boundary carve-out. - move-sui-audit-checklist.md: add Refactor & API-surface safety section. - rule-sweep.workflow.js: recalibrate test-coverage family (reachable-only + testability; drop stale .move.disabled note). Verified at HEAD: terminal_floor_index/floor_index = 0 occurrences, backing_buffer_lambda exists, 0 .move.disabled files. (The matching ROUNDING_POLICY.md R1-scope edit stays local -- .claude/predict-design/ is gitignored.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tonylee08
approved these changes
Jun 29, 2026
tonylee08
left a comment
tonylee08
left a comment
Collaborator
There was a problem hiding this comment.
Lgtm but let's include public function param changes like redeem_settled in PR description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key decisions
walk_linearexact by default; this change removes zero-node bloat without changing the interpolation policy.Test plan
git diff --checkgit diff --cached --checksui move build --path packages/predict --warnings-are-errorssui move test --path packages/predict --gas-limit 100000000000