docs: automated updates for api_change#612
Open
jessiemongeon1 wants to merge 4 commits into
Open
Conversation
Automated update based on: New SignCommitteeTransition RPC added where peers sign with historical epoch BLS keys. Leader now drives guardian committee handoff to match on-chain epoch.
Automated update based on: New SignCommitteeTransition RPC added where peers sign with historical epoch BLS keys. Leader now drives guardian committee handoff to match on-chain epoch.
Automated update based on: New SignCommitteeTransition RPC added where peers sign with historical epoch BLS keys. Leader now drives guardian committee handoff to match on-chain epoch.
Automated update based on: New SignCommitteeTransition RPC added where peers sign with historical epoch BLS keys. Leader now drives guardian committee handoff to match on-chain epoch.
Collaborator
Author
Style Guide AuditAudited 4 file(s) against the Sui Documentation Style Guide. 12 violation(s) found. All must be fixed before merge.
|
jon-mysten
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated documentation updates triggered by recent release notes.
Changes
Triggered by MystenLabs/hashi#568: [leader] drive guardian committee handoff
design/docs/service.mdxdesign/docs/guardian.mdxdesign/docs/reconfiguration.mdxdesign/docs/committee.mdxReview details
design/docs/service.mdxLooking at this documentation page, I need to assess whether it covers the new
SignCommitteeTransitionRPC and the guardian committee handoff mechanism driven by the leader to match on-chain epochs.Analysis
The page describes the gRPC
HashiServiceinterface that committee members expose, but it does not enumerate or describe specific RPCs. The page also discusses the on-chain state (committee, config, etc.) but does not describe:The
SignCommitteeTransitionRPC — a new RPC endpoint where peers sign with historical epoch BLS keys. This is a new addition to theHashiServicegRPC interface and should be documented.Guardian committee handoff / epoch transition — the mechanism by which the leader drives guardian committee handoff to match the on-chain epoch. The page mentions the
committeeblock in the on-chain state diagram but doesn't describe how committee transitions work or how the leader coordinates them.Suggested Updates
1. Add a section on gRPC RPCs (or expand the existing description)
The page currently only says the service "serves a gRPC
HashiService" without listing the RPCs. A section should be added (e.g., after the introductory paragraph or as a new heading like## gRPC Interfaceor## HashiService RPCs) that describes the available RPCs, includingSignCommitteeTransition. This RPC should be described as an endpoint where peers sign committee transition messages using their historical epoch BLS keys.2. Add a section on committee transitions / epoch handoff
Either as a new section (e.g.,
## Committee Transitions) or as an expansion of the on-chain state description, the page should describe:SignCommitteeTransition3. Update the Mermaid diagram (optional)
The on-chain state diagram shows
committeeas a block but doesn't convey that committee state includes historical epoch information or that transitions are tracked. Consider annotating or expanding this to reflect epoch-aware committee state.design/docs/guardian.mdxThe documentation page at
guardian.mdis essentially a stub — it contains only a brief conceptual description of the withdrawal guardian and a note that "Additional details about the guardian integration are added before Testnet."The PR introduces a new
SignCommitteeTransitionRPC where peers sign with historical epoch BLS keys, and describes how the leader now drives guardian committee handoff to match on-chain epoch. This is directly relevant to the guardian's role in committee transitions.What needs updating:
New section: "Committee Transition Signing" (or similar) — The page should document the
SignCommitteeTransitionRPC, explaining:New section or subsection: "Guardian Committee Handoff" — The page should explain:
What is currently missing:
Suggested update:
Expand the page to include at minimum:
SignCommitteeTransitionRPC and its role in the guardian workflow.design/docs/reconfiguration.mdxLooking at this documentation page against the PR description, I need to identify what's new:
SignCommitteeTransitionRPC - where peers sign with historical epoch BLS keysLet me analyze what the current page covers:
The current page describes the reconfiguration flow, including the BLS signing step in the "DKG or Key Rotation" section:
However, the PR introduces a new and distinct concept: a
SignCommitteeTransitionRPC where peers sign with historical epoch BLS keys. This is different from theReconfigCompletionMessagesigning described above. The "committee transition" and "guardian committee handoff" driven by the leader appear to be a new mechanism related to how the guardian committee (which may be distinct from or related to the Hashi committee) is handed off to match the on-chain epoch.Updates needed:
In the "DKG or Key Rotation" section or a new subsection — The page should document the
SignCommitteeTransitionRPC. This is a new RPC endpoint where peers sign using historical epoch BLS keys (not just current-epoch keys). The current text only mentions signingReconfigCompletionMessagevia generic "RPC" — it doesn't mentionSignCommitteeTransitionor the use of historical BLS keys. A brief description should be added explaining:SignCommitteeTransitionRPC and its purposeLeader-driven guardian committee handoff — The page does not mention the concept of a "guardian committee" or that a leader drives the handoff to match the on-chain epoch. This could be added either in the "End Reconfig" section or as a new subsection after it, explaining:
The page currently treats reconfiguration as a relatively symmetric process among committee members. The introduction of a leader-driven handoff and a specific new RPC for committee transition signing with historical keys represents a meaningful architectural addition that should be documented.
design/docs/committee.mdxLooking at this documentation page against the PR changes:
The PR introduces a new
SignCommitteeTransitionRPC where peers sign with historical epoch BLS keys, and describes how the leader now drives guardian committee handoff to match on-chain epoch.The current documentation page covers the conceptual design of the committee — registration information, why the committee is a subset of validators, and the general need for hand-off between old and new committees. It does not cover:
Specific RPCs or protocol mechanics — The page doesn't mention any RPCs at all, so the new
SignCommitteeTransitionRPC isn't something that would naturally be documented here unless the page's scope is expanded.How the hand-off is driven — The last paragraph mentions that hand-off "requires that
2f+1stake-weighted members of the old committee are alive and willing to participate" but does not describe the mechanism by which the hand-off is coordinated. The PR introduces the concept that the leader drives the guardian committee handoff to match the on-chain epoch, and that peers sign with historical epoch BLS keys during this process.Suggested updates:
In the last paragraph (starting with "The one downside of not having tight coupling..."), the page should be expanded to describe the hand-off mechanism in more detail:
SignCommitteeTransitionRPC.Consider adding a subsection such as
## Committee Transitionor## Hand-off Processafter the current last section, covering:SignCommitteeTransitionRPC and its purposeThis is important because the page already discusses the hand-off conceptually but lacks the concrete mechanism that the PR implements.
This PR was automatically generated by the Docs Impact Monitor. Please review the changes carefully before merging.
Each file edit was generated by Claude based on the release notes and a review of the existing documentation content.