[btc-monitor] Never rotate the trusted peer connection on a timer#676
Draft
0xsiddharthks wants to merge 1 commit into
Draft
[btc-monitor] Never rotate the trusted peer connection on a timer#6760xsiddharthks wants to merge 1 commit into
0xsiddharthks wants to merge 1 commit into
Conversation
Kyoto's default max_connection_time silently ends every connection after 2h, and with whitelist_only each rotation consumes a whitelist entry: the node exits with NoReachablePeers every ~4h like clockwork (the 240-minute restart metronome on devnet) and pays a full resync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kyoto's default
max_connection_timesilently ends every peer connection after 2 hours, and withwhitelist_onlyeach rotation consumes a whitelist entry — so each node's kyoto died withNoReachablePeersevery ~4 hours like clockwork (devnet's 240-minute restart metronome, 54 exits in 48h) and paid a full resync. Our peers are our own trusted bitcoin-core nodes, so never rotate them on a timer.Pairs with sui-operations#8134; upstream kyoto fixes for the remaining disconnect causes (whitelist retry, inv deafness) are in flight.