Skip to content

Nitpick at dynamic fields example#140

Open
alilloig wants to merge 1 commit into
MystenLabs:mainfrom
alilloig:patch-1
Open

Nitpick at dynamic fields example#140
alilloig wants to merge 1 commit into
MystenLabs:mainfrom
alilloig:patch-1

Conversation

@alilloig

@alilloig alilloig commented May 6, 2025

Copy link
Copy Markdown
Contributor

Since that's the main difference between objects stored as df and objects stored as dof is that the former do not need to have the key ability, I believe is worth clarifying that on the example, or at least not having both objects that are gonna be used for df having key.

Add an extra clarification pointing out that objects added as df do not need to have key ability, since that's the main difference between df and dof
@damirka

damirka commented May 21, 2025

Copy link
Copy Markdown
Collaborator

I agree that it makes sense to mark key as not necessary, but the idea is that you can own Mustache object, and it's intentionally an object which can be owned and taken off.

@alilloig

Copy link
Copy Markdown
Contributor Author

My point was that you could see that df can own objects since Hat is also being attached, but by making Mustache a non object struct we made emphasis on the difference with dof.

But as I said, absolut nitpick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants