feat: complete external module method aliasing example#187
Open
mason0510 wants to merge 1 commit into
Open
Conversation
- Removed TODO comment and implemented complete example - Added proper BCS import and method aliasing syntax - Implemented working test with assertions - Uncommented the corresponding documentation section - Demonstrates how to alias external module methods as struct methods
Collaborator
|
Hey @mason0510, thank you for your contribution. Aliasing example had a reason to be commented out. See CI's output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
The
struct-methods-3.movefile contained a TODO comment and incomplete example for demonstrating external module method aliasing. The corresponding documentation section was commented out.Changes Made
struct-methods.mdTechnical Details
The example shows how to use
public use fun bcs::to_bytes as Hero.to_bytesto create a method alias that allows callinghero.to_bytes()directly on Hero instances, making the external BCS serialization method feel like a native struct method.Testing
Impact