Skip to content

chore: cleanup std::future::Future use in various places#2808

Merged
wbbradley merged 1 commit into
mainfrom
cleanup-future-use
Jan 15, 2026
Merged

chore: cleanup std::future::Future use in various places#2808
wbbradley merged 1 commit into
mainfrom
cleanup-future-use

Conversation

@wbbradley

@wbbradley wbbradley commented Dec 28, 2025

Copy link
Copy Markdown
Contributor

Description

Improve readability of daemon.rs.

@github-actions

github-actions Bot commented Dec 28, 2025

Copy link
Copy Markdown
Contributor

Warning: This PR modifies one of the example config files. Please consider the
following:

  • Make sure the changes are backwards compatible with the current configuration.
  • Make sure any added parameters follow the conventions of the existing parameters; in
    particular, durations should take seconds or milliseconds using the naming convention
    _secs or _millis, respectively.
  • If there are added optional parameter sections, it should be possible to specify them
    partially. A useful pattern there is to implement Default for the struct and derive
    #[serde(default)] on it, see BlobRecoveryConfig as an example.
  • You may need to update the documentation to reflect the changes.

@wbbradley wbbradley changed the base branch from main to streaming-slivers December 28, 2025 22:54
@wbbradley wbbradley force-pushed the streaming-slivers branch 3 times, most recently from fe689cb to ddd151c Compare January 14, 2026 04:17
Base automatically changed from streaming-slivers to main January 15, 2026 16:48
@wbbradley wbbradley force-pushed the cleanup-future-use branch 2 times, most recently from 293c512 to 67ed3e5 Compare January 15, 2026 16:55
@wbbradley wbbradley marked this pull request as ready for review January 15, 2026 16:57
@wbbradley wbbradley requested a review from halfprice January 15, 2026 16:57
@wbbradley wbbradley merged commit 47fd831 into main Jan 15, 2026
25 of 26 checks passed
@wbbradley wbbradley deleted the cleanup-future-use branch January 15, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halfprice halfprice halfprice approved these changes

@sadhansood sadhansood sadhansood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wbbradley @halfprice @sadhansood