feat: allow configuration of max_body_size_limit in upload relay#2809
feat: allow configuration of max_body_size_limit in upload relay#2809wbbradley wants to merge 1 commit into
Conversation
wbbradley
force-pushed
the
variable-upload-relay-max-size
branch
from
1bf0cee to
3e7c06a
Compare
|
Warning: This PR modifies one of the example config files. Please consider the
|
wbbradley
changed the title
wbbradley
force-pushed
the
variable-upload-relay-max-size
branch
from
3e7c06a to
d88e09a
Compare
halfprice
left a comment
halfprice
left a comment
There was a problem hiding this comment.
LGTM! It'll be great if we can test that this works as expected, since a simple test case that stores limit size +1 would do it.
| match basic_store_and_read( | ||
| &cluster_client, | ||
| 1, | ||
| BLOB_SIZE, | ||
| Some(upload_relay_client), | ||
| || Ok(()), | ||
| ) |
There was a problem hiding this comment.
suggestion: looks like you can add a simple test case where the test tries to store BLOB_SIZE +1, and expect to get rejected.
| tip_config: TipConfig::NoTip, | ||
| tx_freshness_threshold: Duration::from_mins(5), | ||
| tx_max_future_threshold: Duration::from_secs(10), | ||
| max_body_size_limit: BLOB_SIZE, |
There was a problem hiding this comment.
question: this could be set to anything that is larger than BLOB_SIZE, is that correct? Any particular reason to use BLOB_SIZE instead of the default_max_body_size_limit() here?
wbbradley
force-pushed
the
variable-upload-relay-max-size
branch
from
d88e09a to
d48ac69
Compare
|
This PR is stale because it has been open 14 days with no activity. It will be closed in 7 days unless you remove the |
|
This PR was closed because it has not seen any activity since being marked as stale. |
2 participants
Description
Allow configuration of max_body_size_limit in upload relay.
Test plan
Manual testing. CI Pipeline.