chore: decouple WalrusClient from CliCommandRunner#2818
Draft
wbbradley wants to merge 17 commits into
Draft
Conversation
Contributor
|
Warning: This PR modifies the Walrus CLI. Please consider the following:
|
wbbradley
force-pushed
the
sdk-refactor-02
branch
from
1d22e29 to
9fa0186
Compare
wbbradley
force-pushed
the
sdk-refactor-02
branch
from
9fa0186 to
53ba9ed
Compare
wbbradley
force-pushed
the
sdk-refactor-03
branch
from
5410b44 to
3f3fc8d
Compare
Refactors Wallet to be Clone-able by wrapping WalletContext in Arc<Mutex<...>> and caching immutable properties (active address, environment, config path) at construction time. This moves validation from accessor methods to the constructor, eliminating many ? operators and &mut self requirements throughout the codebase. This is a step toward making ClientCommandRunner reusable across multiple invocations, and is orthogonal to the upcoming gRPC transition.
wbbradley
force-pushed
the
sdk-refactor-03
branch
from
3f3fc8d to
03b85fd
Compare
wbbradley
force-pushed
the
sdk-refactor-02
branch
from
53ba9ed to
fe897d1
Compare
Contributor
|
This PR is stale because it has been open 14 days with no activity. It will be closed in 7 days unless you remove the |
Contributor
Author
|
Still working on this. |
wbbradley
force-pushed
the
sdk-refactor-02
branch
2 times, most recently
from
8f105b0 to
3bbb47b
Compare
wbbradley
force-pushed
the
sdk-refactor-02
branch
from
3bbb47b to
2150d47
Compare
wbbradley
force-pushed
the
sdk-refactor-02
branch
2 times, most recently
from
86a7459 to
e2d28e9
Compare
wbbradley
force-pushed
the
sdk-refactor-02
branch
from
e2d28e9 to
22f7ea4
Compare
Contributor
|
This PR is stale because it has been open 14 days with no activity. It will be closed in 7 days unless you remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.