chore: explicitly set localnet environment in all walrus packages in test to work with new package management system in Sui 1.63#2822
Merged
halfprice merged 14 commits intoJan 9, 2026
Conversation
halfprice
changed the title
Contributor
|
Warning: This PR modifies the Walrus CLI. Please consider the following:
|
halfprice
force-pushed
the
zhewu/bump-sui-to-1.63
branch
from
14933fd to
6909293
Compare
halfprice
force-pushed
the
ebmifa/bump-sui-testnet-v1.63.1-20260106230126
branch
from
a86ee41 to
b472f84
Compare
halfprice
force-pushed
the
zhewu/bump-sui-to-1.63
branch
from
6909293 to
594497c
Compare
halfprice
changed the title
halfprice
commented
Jan 9, 2026
| walrus = { local = "../walrus" } | ||
|
|
||
| [environments] | ||
| localnet = "ReplaceChainId" |
Collaborator
Author
There was a problem hiding this comment.
The way the hack works is to replace the existing Move.toml with this Move.test.toml, and update ReplaceChainId with the actual chain ID.
Why can't we just update the existing Move.toml to this? Because we want to maintain compatibility for any contracts that depend on Walrus contract.
wbbradley
approved these changes
Jan 9, 2026
halfprice
merged commit 3439a60
into
ebmifa/bump-sui-testnet-v1.63.1-20260106230126
26 checks passed
github-actions Bot
added a commit
that referenced
this pull request
Jan 9, 2026
* ci: bump Sui testnet version to testnet-v1.63.1 * Empty commit to trigger CI * chore: explicitly set localnet environment in all walrus packages in test to work with new package management system in Sui 1.63 (#2822) * Empty commit to trigger CI * attempt to resolve conflict * fix clippy warning * remove dead code to fix ec issue * chore: package management debugging (#2824) debugging * tmp file * mega fix commit * simtest all fix * fix lint * more format fix * formatting * fix remaining issue * cleanup for review * cleanup --------- Co-authored-by: Eugene Boguslavsky <eugene@mystenlabs.com> Co-authored-by: Will Bradley <will.bradley@mystenlabs.com> Co-authored-by: Karl Wuest <5716112+karlwuest@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Eugene Boguslavsky <eugene@mystenlabs.com> Co-authored-by: Zhe Wu <halfprice@users.noreply.github.com> Co-authored-by: Will Bradley <will.bradley@mystenlabs.com> Co-authored-by: Karl Wuest <5716112+karlwuest@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
resolve conflicts when updating sui to 1.63 in Walrus codebase
This is an effort to integrate the new package management system introduced in sui 1.63. Since the old package
management system is no longer available, we have to make this change in order to integrate Sui 1.63
However, there are some issue related to the new package management system that cause walrus contracts publising
not working in test setup. This is mostly due to that the ephemeral package publishing does not work well with
dependencies that are also an ephemeral published published package.
The work around in this PR is to manually set all the contracts to use a localnet environment, and update its chain ID
during each setup. We create a new Move.test.toml in all the contracts and will use its updated version to replace the
Move.toml in system setup.
Note that this is a temporary solution and should be resolved once the new package management system can work
with ephemeral packages.
Resolve WAL-821
Related to WAL-1125 WAL-1126 WAL-1127
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)