Skip to content

Don't send absolute paths when POSTing the Certificate.upload_cert() request - #471

Open
ddribin wants to merge 1 commit into
N4S4:masterfrom
ddribin:fix/cert-upload-basename
Open

ddribin wants to merge 1 commit into
N4S4:masterfrom
ddribin:fix/cert-upload-basename

Conversation

@ddribin

@ddribin ddribin commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Send hardcoded names ("server.key", "server.crt", and "ca.crt") as the filename of each multipart part.

Resolves #470

🗃️ Summary

What does this pull request do?

Send hardcoded names ("server.key", "server.crt", and "ca.crt") as the filename of each multipart part.


🚀 Motivation & Problem Statement

Why is this PR needed?

Resolves #470

🔧 Implementation Details

What changes were made?

  • List the files affected and the nature of the changes (add, modify, delete).
  • Mention any new tests added or existing ones updated.
  • If it touches the documentation, indicate which sections were updated.

🏁 Checklist

  • I have read and followed the Contributing guidelines.
  • All new or modified code is covered by unit tests (tests/).
  • Tests pass locally (pytest).
  • I added or updated documentation where necessary.
  • I updated the changelog or added a new section if this is a major change.
  • I followed the style guidelines (black, flake8, etc.).
  • I ran pre-commit and addressed any linting issues.

Note: If you added a new API wrapper, please update docs/ and add the
corresponding entries to APIs - Supported APIs in the README.


📝 Related Issue

Issue number(s) this PR addresses
#123


🔨 Additional Notes

Anything else that reviewers should know?

  • Known limitations
  • Required manual steps
  • Performance implications

😎 Test & Build Status

Run the following locally before opening the PR:

pip install -r requirements-dev.txt
pre-commit run --all-files
pytest

pre-commit isn't installed from requirements-dev.txt, and pytest was failing with what looks like an unrelated error.


👀 Screenshots / Media

If your changes include UI changes, API responses, or other visual elements,
please attach screenshots or GIFs.


Thank you for contributing! 🙏

…request

Send hardcoded names ("server.key", "server.crt", and "ca.crt") as the filename of each multipart part.

Resolves N4S4#470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upload_cert() is failing with {'code': 108, 'errors': {'upload_err': -8}}

1 participant