Open
Conversation
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
refactor/filter-builder
branch
from
160c073 to
e128eb9
Compare
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
requested review from
JosephVolosin and
duranb
and removed request for
dandelany,
joswig and
mattdailis
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
force-pushed
the
refactor/filter-builder
branch
from
e128eb9 to
7c3fddf
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
refactor/filter-builder
branch
from
7c3fddf to
025d690
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
refactor/filter-builder
branch
from
d9ea755 to
fa9bcc1
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
reviewed
Jan 26, 2026
| const matchingName = !!acc[parameterName]; | ||
| const matchingEntry = matchingName && acc[parameterName].type === 'variant'; | ||
| if (matchingEntry) { | ||
| // handle enums too? |
Collaborator
There was a problem hiding this comment.
Does this now handle enums with this refactor? I'm a little confused as to what the comment means since it's in a function called handleEnumAttribute
Contributor
Author
There was a problem hiding this comment.
I believe it already handled enums in the line below so the comment should be outdated? @JosephVolosin might be able to confirm?
Contributor
Author
There was a problem hiding this comment.
@duranb Following up on this - yes this is just removing stale TODO comments, no behavior change.
| const matchingName = !!acc[key]; | ||
| const matchingEntry = matchingName && acc[key].type === type; | ||
| if (matchingEntry) { | ||
| // handle enums too? |
Collaborator
There was a problem hiding this comment.
Similar question here as my above question in regards to the comment about enums. Is this just cleanup of a comment that was long addressed before? I'm seeing a reference to "enum" in the logic directly above, so I'm not sure what the previous state was.
AaronPlave
force-pushed
the
refactor/filter-builder
branch
from
fa9bcc1 to
3851270
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
refactor/filter-builder
branch
from
3851270 to
e6dbc87
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
refactor/filter-builder
branch
from
e6dbc87 to
b9fd532
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
refactor/filter-builder
branch
from
b9fd532 to
890d666
Compare
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
force-pushed
the
refactor/filter-builder
branch
from
890d666 to
e2a7942
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the activity and external event filter builders to share common code. Closes #1803