Skip to content

Fixes sequence output editor not applying appropriate linting#1898

Merged
dandelany merged 3 commits intodevelopfrom
fix/sequence-output-linting
Apr 22, 2026
Merged

Fixes sequence output editor not applying appropriate linting#1898
dandelany merged 3 commits intodevelopfrom
fix/sequence-output-linting

Conversation

@duranb
Copy link
Copy Markdown
Collaborator

@duranb duranb commented Mar 24, 2026

This ensures the editor output view correctly refreshes when its configuration changes.

To test:

  1. Add an adaptation that has linting for something other than SeqJSON as the output language.
  2. Create a workspace using a parcel that uses that adaptation.
  3. Create a file in the workspace that corresponds to the input language of the adaptation.
  4. Verify that the output does not show incorrect linting errors.

@duranb duranb requested a review from a team as a code owner March 24, 2026 17:25
@duranb duranb temporarily deployed to test-workflow March 24, 2026 17:48 — with GitHub Actions Inactive
Comment thread src/components/sequencing/SequenceEditor.svelte Outdated
@duranb duranb force-pushed the fix/sequence-output-linting branch from 0e43a5b to e5135c7 Compare April 22, 2026 17:27
@duranb duranb temporarily deployed to test-workflow April 22, 2026 17:27 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow April 22, 2026 19:15 — with GitHub Actions Inactive
duranb added 2 commits April 22, 2026 16:10
This ensures the editor output view correctly refreshes when its configuration changes.
…econfiguration

- Remove previousOutputEditorExtension tracking and safeStringify comparison
- Add explicit empty array fallback when no output extension is available
- Move output format initialization before extension computation for proper dependency order
- Replace complex conditional logic with simpler reactive statement for output editor updates
- Add dedicated reactive block to reconfigure output editor when adaptation extensions change
@dandelany dandelany force-pushed the fix/sequence-output-linting branch from 366ba4f to 0e7fdd4 Compare April 22, 2026 23:10
@dandelany dandelany merged commit 8253915 into develop Apr 22, 2026
5 checks passed
@dandelany dandelany deleted the fix/sequence-output-linting branch April 22, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants